Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SpawnStageBatches function #1476

Open
Stefan-Ethernal opened this issue Nov 15, 2024 · 1 comment
Open

Refactor SpawnStageBatches function #1476

Stefan-Ethernal opened this issue Nov 15, 2024 · 1 comment

Comments

@Stefan-Ethernal
Copy link
Collaborator

The SpawnStageBatches is large (cdk-erigon/zk/stages/stage_batches.go at 1c66851ea12ffde9bf2c1ba0fc4c54d293635157 · 0xPolygonHermez/cdk-erigon ), which makes it hard to understand and maintain. Consider refactoring it into smaller, manageable, and easier-to-understand and maintain functions.
@Stefan-Ethernal Stefan-Ethernal changed the title Refactor SpawnStageBatches function Refactor SpawnStageBatches function Nov 15, 2024
@V-Staykov
Copy link
Collaborator

This is already refactored and a lot shorter with the latest changes:
https://github.com/0xPolygonHermez/cdk-erigon/blob/zkevm/zk/stages/stage_batches.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MorettiGeorgiev @V-Staykov @Stefan-Ethernal