You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The miden-tx-prover CLI includes two services: worker (prover) and proxy. The worker receives through the CLI command the port in which will run. The proxy is a bit more complex, using a configuration file AND parameters from the CLI command.
Maybe the best option is to standardize this and remove the configuration file, and make command's argument "compatible" with env vars (using clap's env feature) as @Mirko-von-Leipzigsuggested.
How should it be done?
We need to remove the init command and the configuration file.
Add the env feature for clap.
Add the configurable fields to the corresponding command.
Create an .env.example file with the default values.
In this issue we can also tackle the addition of trace_sampling_ratio (as mentioned here) and OTEL_EXPORTER_OTLP_ENDPOINT to the configurations.
When is this task done?
Additional context
No response
The text was updated successfully, but these errors were encountered:
What should be done?
The
miden-tx-prover
CLI includes two services: worker (prover) and proxy. The worker receives through the CLI command the port in which will run. The proxy is a bit more complex, using a configuration file AND parameters from the CLI command.Maybe the best option is to standardize this and remove the configuration file, and make command's argument "compatible" with env vars (using clap's
env
feature) as @Mirko-von-Leipzig suggested.How should it be done?
init
command and the configuration file.env
feature for clap..env.example
file with the default values.In this issue we can also tackle the addition of
trace_sampling_ratio
(as mentioned here) andOTEL_EXPORTER_OTLP_ENDPOINT
to the configurations.When is this task done?
Additional context
No response
The text was updated successfully, but these errors were encountered: