Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AccountData #1101

Closed
igamigo opened this issue Jan 24, 2025 · 2 comments
Closed

Rename AccountData #1101

igamigo opened this issue Jan 24, 2025 · 2 comments
Labels
good first issue Good for newcomers
Milestone
v0.8

Comments

@igamigo
Copy link
Collaborator

igamigo commented Jan 24, 2025

What should be done?

As described here, AccountData is not a great name for the struct. We should find a better name and change the struct accordingly.

How should it be done?

Rename AccountData. A good candidate might be AccountFile, to be in line with NoteFile since they have a similar role.

When is this task done?

When AccountData and docs have been renamed.

Additional context

No response
@igamigo igamigo added the good first issue Good for newcomers label Jan 24, 2025
@bobbinth bobbinth added this to the v0.8 milestone Jan 24, 2025
@bobbinth
Copy link
Contributor

A good candidate might be AccountFile, to be in line with NoteFile since they have a similar role.

Yes, I think this works - makes things a bit more consistent.

@sergerad sergerad mentioned this issue Feb 2, 2025
Merged
@bobbinth
Copy link
Contributor

bobbinth commented Feb 2, 2025

Closed by #1116.

@bobbinth bobbinth closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
2 participants
@igamigo @bobbinth