From e08e30423436c5855ee528172a09f82afd86de46 Mon Sep 17 00:00:00 2001 From: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com> Date: Thu, 27 Feb 2025 22:21:23 +0100 Subject: [PATCH 1/2] fix(api): object parameter jsdoc --- .../infrastructure/repositories/candidate-repository.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js b/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js index 779a5950290..9cca8d5ee00 100644 --- a/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js +++ b/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js @@ -5,7 +5,7 @@ import { Candidate } from '../../domain/models/Candidate.js'; * This function find candidates with a certification-course but no reconciledAt * * @param {Object} params - * @param {number} params.[limit] - number of candidates to limit to + * @param {number} [params.limit] - number of candidates to limit to * @returns {Array} - Candidates returned have a reconciledAt built from certification-course */ export const findCandidateWithoutReconciledAt = async function ({ limit } = {}) { From 718fbd93d16eff7d6dacecd852c408da4793b0e9 Mon Sep 17 00:00:00 2001 From: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com> Date: Thu, 27 Feb 2025 22:21:43 +0100 Subject: [PATCH 2/2] fix(api): add a default limit to avoid errors --- .../infrastructure/repositories/candidate-repository.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js b/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js index 9cca8d5ee00..32172e26a05 100644 --- a/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js +++ b/api/src/certification/configuration/infrastructure/repositories/candidate-repository.js @@ -8,7 +8,7 @@ import { Candidate } from '../../domain/models/Candidate.js'; * @param {number} [params.limit] - number of candidates to limit to * @returns {Array} - Candidates returned have a reconciledAt built from certification-course */ -export const findCandidateWithoutReconciledAt = async function ({ limit } = {}) { +export const findCandidateWithoutReconciledAt = async function ({ limit } = { limit: 1 }) { const knexConn = DomainTransaction.getConnection(); const data = await knexConn('certification-candidates') .select('certification-candidates.id', 'certification-courses.createdAt')