Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eleventy Transform: ignore <img> inside of <picture> with other sources. #214

Open
zachleat opened this issue Feb 13, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@zachleat
Copy link
Member

Or better: optimize and replace instances of <picture>.

#208

@zachleat zachleat added the enhancement New feature or request label Feb 13, 2024
@what1s1ove
Copy link

Hey @zachleat !

Could you please tell me if this will help solve the following problem:

Often, I need to have a picture element in advance to apply a class to it.

.intro__picture {}

But this leads to a nested picture element appearing in the markup after the plugin has processed it.

<picture class="intro__picture"> <!-- My picture element -->
  <picture> <!-- The picture element from 11ty plugin -->
    <img />
  </picture>
</picture>

As a result, I have to remove the picture element I wrote and rely on the one created by the plugin after it processes. However, writing styles in this case becomes difficult.

.intro picture {}

Sometimes, there is more than one image in a block, which means additional wrappers need to be created, etc. It seems to me that it would be good if the picture element that appears after the plugin is processed either took all the attributes from the current picture element, or if the plugin completely ignored creating a picture element if one already exists in the markup.

@ItsEthanH
Copy link

ItsEthanH commented Jun 12, 2024

Just bumping this up as I'm having the same issue @what1s1ove is.

If there was a way to add classes to the <picture>s generated from the Transform Plugin, it would make the usability of the plugin that much better.

I know this plugin does something similar:
https://github.com/saneef/eleventy-plugin-img2picture

Perhaps we can add a hoistClass option to the image config? Or maybe an attribute override, similar to eleventy:widths or eleventy:formats? Or both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants