Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. #27

Open
1j01 opened this issue Jan 12, 2025 · 0 comments
Open

The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. #27

1j01 opened this issue Jan 12, 2025 · 0 comments

Comments

@1j01
Copy link
Owner

1j01 commented Jan 12, 2025

I have a branch where I started switching to AudioWorkletNode: https://github.com/1j01/guitar/tree/worklet (latest commit: f77d309)

State of this branch: basically working with worklet, but...

  1. createScriptProcessor is used in tuna.js anyways, so it will need
    updating in order to actually do away with the warnings,
    and avoid future bit rot.
    ScriptProcessorNode deprecation warnings Theodeus/tuna#88
  2. String bending doesn't work
  3. Maybe there's an error that can occur where fret is undefined?
    Note implicit assignment at play: (@fret)->
    Note there's GuitarStringProcessor::play and GuitarString::play

Tuna.js relies on ScriptProcessorNode, however, someone has created a fork that uses audio worklets, so it may be worth picking up this work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant