Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ok! and Error! with a green [OK] and a red [KO] respectively. #294

Closed
wants to merge 1 commit into from

Conversation

abdlalisalmi
Copy link

Replace Ok! and Error! with a green [OK] and a red [KO] respectively, and made them as a prefix instead of postfix for readability, (Tests don't work well, since they expect the previous format).

⚠️ Tests need to be modified to match the new messages format: ⚠️

Examples

Screen Shot 2022-02-13 at 6 23 57 PM

… and made them as a prefix instead of postfix for readability, (Tests don't work well, since they expect the previous format)
Copy link

@zylosophe zylosophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, but it seems like the code will change a lot after the version 3.3.55 (commit beaffat), making these code impossible to merge like this. I just made a pull request for the last version (adding other things too) here #490.

@Asandolo
Copy link

Hello ! we chose to merge this MR for color, thanks you !

@Asandolo Asandolo closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants