Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5ET-1286 Option to pick homebrew entity name color for light mode and dark mode separately #1319

Open
crawltracker opened this issue Jan 22, 2025 · 0 comments
Labels
featurereq Feature request

Comments

@crawltracker
Copy link
Collaborator

crawltracker commented Jan 22, 2025

Information
At the moment, you can only input one color in homebrew's schema and it'll be used for both light and dark mode on the website. However, some colors only work well with either light or dark mode, having bad contrast with another leading to poor visibility.
So, it'd be great if converters could had an option to assign different colors for light and dark mode separately that work for each one.

Who would use it?
Homebrew converters and users.

How would it work?
in "_meta": of the file, in "color":, instead of inputting one color hex in quotes, give an option to input different colors for light and dark mode. That way, converter can either input different colors for light and dark mode, or opt to use the ye old method and input one color for both.

Why should this be added?
It gives an option for homebrewers to pick colors that work for each theme, ensuring better readability and user experience for those who use that homebrew.

  • foopsie42 (Foo)

Indifferent - f0rgetful (absentminded)

Indifferent - revilowaldow (Lyra)

Indifferent - spap (Spappz)

Note - giddy_ (Giddy)

This would involve switching to injected classes (as opposed to inline styles) to support theme switching. Sharp edges likely include: cross-browser compatibility; ensuring correct behaviour in popped-out browser windows; dynamically adding after initial homebrew load (i.e. in Plutonium).

Upvote - hazmat. (Hazmat)

Upvote - kolariah (Kolariah)

Indifferent - thandul (Thandul)

Upvote - tsari6822 (Tsar I)

Indifferent - pablomorais121 (Pablomorais121)

Upvote - asdfgn2399 (asdfgn)

Upvote - zaplion (Zaplion)

Upvote - fireball64 (fireball64)

Votes: +6 / -0 / ±5

@crawltracker crawltracker added the featurereq Feature request label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
featurereq Feature request
Projects
None yet
Development

No branches or pull requests

1 participant