Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Cypress not working with Cypress 10.3.0 #66

Open
Smriti-Suhag opened this issue Jul 6, 2022 · 3 comments
Open

Open Cypress not working with Cypress 10.3.0 #66

Smriti-Suhag opened this issue Jul 6, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Smriti-Suhag
Copy link

Describe the bug
CypressHelper.commandForOpen is opening cypress as below:
npx cypress open --config testFiles=%path%
However with cypress update v10.3.0 - testFiles is invalid now.
Instead e2e.specPattern should be used.

To Reproduce
Steps to reproduce the behavior:

  1. Click on open cypress lens above spec
  2. Cypress opens but with error.

Expected behavior
To open the cypress without error.

Environment (please complete the following information):

  • Extension version: v1.2.2
  • VS Code version: 1.67.1
  • OS: Mac:

** Developer Tools Console Output **

Additional context
Add any other context about the problem here.

@Smriti-Suhag Smriti-Suhag added the bug Something isn't working label Jul 6, 2022
@Shelex
Copy link
Contributor

Shelex commented Jul 26, 2022

Hi @Smriti-Suhag
Thank you for opening an issue.
Due to publishing token expiration and missing option to regenerate new one I have forked plugin under my personal account:

Cypress Helper v2
Repository
In case you have found this extension via pack, it is also republished - extension pack

Support for cypress v10 is added in forked version of extension in v2.6.0

@Smriti-Suhag
Copy link
Author

Screenshot 2022-07-27 at 1 38 23 PM

@Shelex the command is still using --testFiles. 😕

@Shelex
Copy link
Contributor

Shelex commented Jul 27, 2022

@Smriti-Suhag
Yes, to keep extension working for previous Cypress versions default command was not changed (npx cypress open). But if cypressHelper.commandForOpen configuration contains command with --e2e flag it treats it as cypress v10.

However, I agree that is not intuitive, so I have added an automatic package.json check in latest version (2.7.0) to detect spec flag name based on cypress version in dependencies or devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants