Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP Meeting - 3 August 2021 #91

Open
sarahcleary opened this issue Jun 9, 2021 · 11 comments
Open

RP Meeting - 3 August 2021 #91

sarahcleary opened this issue Jun 9, 2021 · 11 comments
Labels

Comments

@sarahcleary
Copy link
Contributor

Review of Peanut Model - APSIMInitiative/ApsimX#4075

@hut104 to present

@APSIMInitiative/reference-panel - Please let me know if you have suggestions for additional attendees.

@APSIMInitiative/steering-committee - FYI. If you would like to attend, please let me know and I'll forward the meeting invitation.

Information for Developer

  • Upload the presentation at least a week prior to the meeting to the relevant issue - Create a new peanut model ApsimX#4075

  • Ideally presentation should be approximately 30 min

  • Model to be moved into “Under Review” and upload the Model Documentation to APSIM Next Generation

  • At the end of the meeting, it is anticipated that the AI RP will provide a list of tasks if complete will allow for the Model to move into Release and be available as part of the APSIM download.

Information for Reviewers

  • Please review presentation and the Model prior to the meeting.
  • Any key issues or relevant papers, please provide via this issue prior to the meeting for consideration by the Developer.
@sarahcleary
Copy link
Contributor Author

@sarchontoulis unable to attend meeting. Fernando Miguez has been invited to attend from ISU.

@yashvirchauhan
Copy link

yashvirchauhan commented Jun 9, 2021 via email

@sarahcleary
Copy link
Contributor Author

thanks @yashvirchauhan - can you please send me these emails directly.
@uqghamme - I'll forward you the meeting invite

@sarahcleary
Copy link
Contributor Author

@femiguez

@sarahcleary
Copy link
Contributor Author

Please note presentation can be accessed here - APSIMInitiative/ApsimX#4075 (comment)

@sarahcleary
Copy link
Contributor Author

Apologies from @MarkLieffering

@sarahcleary
Copy link
Contributor Author

Apologies from @JulianneLilley

@jbrider
Copy link
Contributor

jbrider commented Aug 2, 2021

Some graph issues...
Kingaroy8384

  • Phenology -> Predicted EmergenceDAS doesn't have any observed values and only 1 of 3 cultivars show values (same emergence?)

Kunnunara8283

  • TimeSeries -> Biomass -> TMax line not present in legend - this happens in a few charts

.Simulations.Validation.Australia.Loxton9697.Growing Season Mean Air Temperature

  • series1 has no name

.Simulations.Validation.Australia.Loxton9697.TimeSeries.NodeNumber

  • EventNames added but not appearing on graph

.Simulations.Validation.Australia.Loxton9697.TimeSeries.LAI1

  • LAI1 seems to be a repaet of LAI - except event names are working

.Simulations.Validation.USA.Gainsville EarlyBunch.TimeSeries.StemMass with components

  • components aren't named

@LouisAK
Copy link

LouisAK commented Aug 3, 2021

A minor comment re the pdf document... countries boundaries are missing on the map (section 4.1 P36)

@sarahcleary
Copy link
Contributor Author

2021-08 Minutes

Attendees:

@LouisAK; @hol353; @peter-devoil; @yashvirchauhan; @sarahcleary; @jbrider; @hut104; @sno036; @EnliWang; @kchenu; @Keith-Pembleton; @femiguez

Tuesday 3rd August 2021 - 9:30 am AEST

Meeting recorded – which can be accessed on Teams link for meeting attendees. Any issues, please contact @sarahcleary directly.
Review of Peanut Model - APSIMInitiative/ApsimX#4075
@hut104 ran through the powerpoint – Peanut Model Reference Panel.pptx

Discussion can be found on recording. Please email [email protected] if you wish to have access.

Agreed that Peanut model should be progressed into release. @hol353 to complete.

Additional Actions (but not needed prior to release).
@sno036 to provide @hut104 with local experimental data to enable a further sensibility test.
@Keith-Pembleton to follow up Mark Peoples with regard to Nitrogen experiments
@kchenu proposed powerpoint slides to be part of Autodoc. No direct action from this due to the nature of the autodocumentation.

Also agreed that chickpea should be released APSIMInitiative/ApsimX#158. @yashvirchauhan to follow up with @AllanPeake directly with regard to experimental data and model fit.

@hut104
Copy link

hut104 commented Aug 3, 2021

Phenology -> Predicted EmergenceDAS doesn't have any observed values and only 1 of 3 cultivars show values (same emergence?)
TimeSeries -> Biomass -> TMax line not present in legend - this happens in a few charts
.Simulations.Validation.Australia.Loxton9697.Growing Season Mean Air Temperature
series1 has no name
.Simulations.Validation.Australia.Loxton9697.TimeSeries.NodeNumber
EventNames added but not appearing on graph
.Simulations.Validation.Australia.Loxton9697.TimeSeries.LAI1
LAI1 seems to be a repaet of LAI - except event names are working
.Simulations.Validation.USA.Gainsville EarlyBunch.TimeSeries.StemMass with components
components aren't named

@jbrider I think these are just in the Json file rather than the PDF. Some of these are simply for debug purposes. I don't think any of these are included in the autodoc.

A minor comment re the pdf document... countries boundaries are missing on the map (section 4.1 P36)

@LouisAK The PDF generated today does include country boundaries. Not sure that has changed.

@APSIMInitiative/reference-panel I have also constructed a sensibility test for peanut for Northland in NZ using weather data from Val and soil data from APSoil. I've used the sowing date, population and preferred soil types obtained from articles found on the web. Yield seems to match potential yeilds from same articles. I would still suggest some caution in use for new environments. However, the sensibility test seems plausible for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants