From 528f97715ff8dbc9efe660f5aac55cfac05fa8b8 Mon Sep 17 00:00:00 2001 From: Jake Herrmann Date: Fri, 7 Mar 2025 11:35:13 -0900 Subject: [PATCH 1/2] combine start exec lambda handler tests into one --- tests/test_start_execution.py | 67 ++++------------------------------- 1 file changed, 6 insertions(+), 61 deletions(-) diff --git a/tests/test_start_execution.py b/tests/test_start_execution.py index 85a96026d..2fd4c9d58 100644 --- a/tests/test_start_execution.py +++ b/tests/test_start_execution.py @@ -181,72 +181,17 @@ def test_submit_jobs(): ] -def test_lambda_handler_500_jobs(): +def test_lambda_handler_jobs(): with ( patch('dynamo.jobs.get_jobs_waiting_for_execution') as mock_get_jobs_waiting_for_execution, + patch('dynamo.util.convert_decimals_to_numbers') as mock_convert_decimals_to_numbers, patch('start_execution.submit_jobs') as mock_submit_jobs, - patch.dict(os.environ, {'STEP_FUNCTION_ARN': 'test-step-function-arn'}, clear=True), ): - mock_jobs = list(range(500)) - mock_get_jobs_waiting_for_execution.return_value = mock_jobs - - mock_submit_jobs.return_value = None - - start_execution.lambda_handler({}, None) - - mock_get_jobs_waiting_for_execution.assert_called_once_with(limit=500) - - assert mock_submit_jobs.mock_calls == [call(mock_jobs)] - - -def test_lambda_handler_400_jobs(): - with ( - patch('dynamo.jobs.get_jobs_waiting_for_execution') as mock_get_jobs_waiting_for_execution, - patch('start_execution.submit_jobs') as mock_submit_jobs, - patch.dict(os.environ, {'STEP_FUNCTION_ARN': 'test-step-function-arn'}, clear=True), - ): - mock_jobs = list(range(400)) - mock_get_jobs_waiting_for_execution.return_value = mock_jobs - - mock_submit_jobs.return_value = None - - start_execution.lambda_handler({}, None) - - mock_get_jobs_waiting_for_execution.assert_called_once_with(limit=500) - - assert mock_submit_jobs.mock_calls == [call(mock_jobs)] - - -def test_lambda_handler_50_jobs(): - with ( - patch('dynamo.jobs.get_jobs_waiting_for_execution') as mock_get_jobs_waiting_for_execution, - patch('start_execution.submit_jobs') as mock_submit_jobs, - patch.dict(os.environ, {'STEP_FUNCTION_ARN': 'test-step-function-arn'}, clear=True), - ): - mock_jobs = list(range(50)) - mock_get_jobs_waiting_for_execution.return_value = mock_jobs - - mock_submit_jobs.return_value = None + mock_get_jobs_waiting_for_execution.return_value = 'mock_jobs' + mock_convert_decimals_to_numbers.return_value = 'converted_jobs' start_execution.lambda_handler({}, None) mock_get_jobs_waiting_for_execution.assert_called_once_with(limit=500) - - assert mock_submit_jobs.mock_calls == [call(mock_jobs)] - - -def test_lambda_handler_no_jobs(): - with ( - patch('dynamo.jobs.get_jobs_waiting_for_execution') as mock_get_jobs_waiting_for_execution, - patch('start_execution.submit_jobs') as mock_submit_jobs, - patch.dict(os.environ, {'STEP_FUNCTION_ARN': 'test-step-function-arn'}, clear=True), - ): - mock_get_jobs_waiting_for_execution.return_value = [] - - mock_submit_jobs.return_value = None - - start_execution.lambda_handler({}, None) - - mock_get_jobs_waiting_for_execution.assert_called_once_with(limit=500) - - assert mock_submit_jobs.mock_calls == [call([])] + mock_convert_decimals_to_numbers.assert_called_once_with('mock_jobs') + mock_submit_jobs.assert_called_once_with('converted_jobs') From b979e33740aa7caa3ba78c5671a08902d37346f2 Mon Sep 17 00:00:00 2001 From: Jake Herrmann Date: Fri, 7 Mar 2025 11:39:56 -0900 Subject: [PATCH 2/2] rename test --- tests/test_start_execution.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_start_execution.py b/tests/test_start_execution.py index 2fd4c9d58..e57b36d87 100644 --- a/tests/test_start_execution.py +++ b/tests/test_start_execution.py @@ -181,7 +181,7 @@ def test_submit_jobs(): ] -def test_lambda_handler_jobs(): +def test_lambda_handler(): with ( patch('dynamo.jobs.get_jobs_waiting_for_execution') as mock_get_jobs_waiting_for_execution, patch('dynamo.util.convert_decimals_to_numbers') as mock_convert_decimals_to_numbers,