Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent: Refactor Measurements #105

Closed
lsulak opened this issue Nov 1, 2023 · 0 comments · Fixed by #104
Closed

Agent: Refactor Measurements #105

lsulak opened this issue Nov 1, 2023 · 0 comments · Fixed by #104
Assignees
@lsulak
Labels
Agent Issues touching the agent part of the project enhancement New feature or request refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code

Comments

@lsulak
Copy link
Collaborator

lsulak commented Nov 1, 2023

Background

Currently the Measurements and MeasurementResults are a bit unclean and not unified. Try to find a way how to refactor it - also MeasurementProcessor has some class related to it that could be put elsewhere.
@lsulak lsulak added the enhancement New feature or request label Nov 1, 2023
@lsulak lsulak self-assigned this Nov 1, 2023
@lsulak lsulak added Agent Issues touching the agent part of the project refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code labels Nov 1, 2023
@lsulak lsulak mentioned this issue Nov 1, 2023
Merged
lsulak added a commit that referenced this issue Feb 8, 2024
@lsulak
#105: refactoring to have a generic type of the measurement result
fcfe3fb
lsulak added a commit that referenced this issue Feb 9, 2024
@lsulak
#105: making it more secure
67a6d8a
lsulak added a commit that referenced this issue Feb 27, 2024
@lsulak
#105: dropping Measurement in agent and thus simplifying the code eve…
830be6e 
…n more
lsulak added a commit that referenced this issue Feb 28, 2024
@lsulak
#105: changing Enumeration to case objects for easier SerDe in the fu…
098d40b 
…ture using probably circe
lsulak added a commit that referenced this issue Feb 29, 2024
@lsulak
#105: getSimpleName is using reflection, and reflection in Java 8 and…
4a34b7f 
… Java 11 uses different algorithm - JLS3 "Binary Compatibility" you can read more about it if interested; this PR addresses that and removes reflection completely from this SerDe
@benedeki benedeki moved this from 🆕 To groom to 👀 In review in CPS small repos project Mar 6, 2024
lsulak added a commit that referenced this issue Mar 8, 2024
@lsulak
#105: Refactoring Measurement, from Agent side (#104)
a7f3f64 
Mostly refactoring Measurement and a lot of stuff from Agent side
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in CPS small repos project Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsulak lsulak

Labels
Agent Issues touching the agent part of the project enhancement New feature or request refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#105: Refactoring Measurement, from Agent side AbsaOSS/atum-service
1 participant
@lsulak