New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Region code alongside match data #30

Open

okwinza opened this issue Apr 7, 2024 · 0 comments

okwinza commented Apr 7, 2024 •

edited

Loading

Hey there!

We're workong on a Reflex DB analyzer tool and since there is no region info we are forced to fetch it from config.wtf which is not quite reliable.

Currently Reflex stores realm & character names but it would be really helpful to also store the current region of the match.

There is an API for that: https://wowpedia.fandom.com/wiki/API_GetCurrentRegion

So I suppose we could add something like

RE.MatchData.Region = GetCurrentRegion()

Somewhere here: https://github.com/AcidWeb/REFlex/blob/master/REFlex.lua#L892

If there is any way to sponsor a PR for this I'd be glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment