Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display place in ComfyUI queue for processing #1137

Open
DVDMAN77 opened this issue Sep 2, 2024 · 5 comments · May be fixed by #1156
Open

Display place in ComfyUI queue for processing #1137

DVDMAN77 opened this issue Sep 2, 2024 · 5 comments · May be fixed by #1156

Comments

@DVDMAN77
Copy link

DVDMAN77 commented Sep 2, 2024

Hi @Acly could be nice to improve the AI Diffusion plugin to display the place in the server processing queue when connected via the remote server option.
When several users do requests an AI generated process (generate, fill, expand, etc.) to a single server they have no visibility on and cannot access as a ComfyUI server processing view, they cannot know wheter they're they are the next ones, or 50th in queue. Could be useful at least to know this kind of information for them to wait or cancel.
Waiting time would also be helpful but I presume this one might be tricky to provide, depending on processing time from various other requests and hardware capabilities.

Thank you! :-)
@FeepingCreature
Copy link
Contributor

FeepingCreature commented Sep 4, 2024 •
edited
Loading

So far as I can tell this comes down to hitting /api/queue to see the remote queued tasks whenever we get a "status" notification, which usually corresponds to a "queue_remaining" change. Then we can tell how far down the queue our own task is. I'd like to take this one, it seems fun and easy. @Acly Does that seem a viable approach?

@Acly
Copy link
Owner

Acly commented Sep 4, 2024

That should work.

Note that:

  • Cancel current will cancel the currently running job even if it's "not yours"
  • Cancel all will cancel ALL jobs (including those of other users)

Sounds like maybe those things should also be changed/fixed to make it actually useful.

I'm rather hesitant regarding comitting work to multi-user Comfy, it's pretty barebones on the server end. And probably quite niche? But no objections if it's not too complex.

@DVDMAN77
Copy link
Author

DVDMAN77 commented Sep 5, 2024 •
edited
Loading

Thank you both @FeepingCreature & @Acly , your solutions seem pretty good to my ears.
1/ Queue position display for any user on AI plugin in Krita
2/ Modify the "Cancel current" + "Cancel all" buttons behaviors in the Krita AI plugin for them to apply only to the specific user's queued jobs, this would be great indeed
THANK YOU for your work, can't wait!! :-)

@FeepingCreature FeepingCreature linked a pull request Sep 6, 2024 that will close this issue
Open
@DVDMAN77
Copy link
Author

DVDMAN77 commented Sep 7, 2024

Thank you so much @FeepingCreature !
Can't wait to test it with the next release of the great AI Diffusion plugin :-)

@FeepingCreature
Copy link
Contributor

FeepingCreature commented Sep 7, 2024 •
edited
Loading

Patience, it's not merged yet :) These things take time.

This is just a first proposal. Now we'll see how it fits in the codebase.

@Acly Acly mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 1137: Display ComfyUI Queue State FeepingCreature/krita-ai-diffusion
3 participants
@FeepingCreature @Acly @DVDMAN77