Skip to content

Latest commit

 

History

History
52 lines (38 loc) · 2.34 KB

feedback.md

File metadata and controls

52 lines (38 loc) · 2.34 KB

Solar System

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Implements Planet class. The initialize stores parameters as instance variables with appropriate reader methods ✔️
Planet class has a summary method, which returns a string ✔️
Implements SolarSystem class. The initialize creates an empty list of planets ✔️
SolarSystem: the add_planet takes an instance of Planet and adds it to the list ✔️
SolarSystem: the list_planets returns a string ✔️
SolarSystem: the find_planet_by_name returns the correct instance of Planet ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Complex functionality is broken out into separate methods ✔️

Functional Requirements

Functional Requirement yes/no
The CLI can list planets and quit ✔️
The CLI can show planet details ✔️
The CLI can add a planet ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 6+ in Code Review && 2+ in Functional Requirements ✔️
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements ✔️
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging ✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized