From 9ccc85c8d373827df1567533bdb19206a649088c Mon Sep 17 00:00:00 2001 From: Daniel Grittner Date: Wed, 20 Nov 2024 15:14:27 +0100 Subject: [PATCH] fix: empty result name handling --- admyral/editor/graph_conversion.py | 5 +---- web/src/lib/workflow-validation.ts | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/admyral/editor/graph_conversion.py b/admyral/editor/graph_conversion.py index 72d6bfe7..5d718fa8 100644 --- a/admyral/editor/graph_conversion.py +++ b/admyral/editor/graph_conversion.py @@ -23,7 +23,6 @@ serialize_json_with_reference, deserialize_json_with_reference, ) -from admyral.utils.collections import is_not_empty def workflow_to_editor_workflow_graph( @@ -175,9 +174,7 @@ def editor_workflow_graph_to_workflow( workflow_dag[node.id] = ActionNode( id=node.id, type=node.action_type, - result_name=node.result_name - if is_not_empty(node.result_name) - else None, + result_name=node.result_name if node.result_name else None, secrets_mapping=node.secrets_mapping, args={ k: deserialize_json_with_reference(v) for k, v in node.args.items() diff --git a/web/src/lib/workflow-validation.ts b/web/src/lib/workflow-validation.ts index c3b760f9..8ba6bd96 100644 --- a/web/src/lib/workflow-validation.ts +++ b/web/src/lib/workflow-validation.ts @@ -9,5 +9,5 @@ export function isValidWorkflowName(name: string): boolean { } export function isValidResultName(name: string): boolean { - return SNAKE_CASE_REGEX.test(name); + return name.length == 0 || SNAKE_CASE_REGEX.test(name); }