Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negative if reusable workflow uses self-hosted runners during org enum #13

Open
AdnaneKhan opened this issue Aug 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AdnaneKhan
Copy link
Owner

AdnaneKhan commented Aug 16, 2024

Describe the bug

When enumerating organizations, Gato-X uses a heuristic to only pull run logs for workflows that potentially use self-hosted runners. This is for speed and to prevent hitting secondary rate limits when pulling run logs.

The problem is that the workflow run log is associated with the calling workflow, so the callee containing the job using a self-hosted runner will not have runs associated with it. The fix here is to use the same parsing logic Gato-X uses for detecting Pwn requests/Injection in called workflows to identify the calling workflow.

@AdnaneKhan AdnaneKhan added the bug Something isn't working label Aug 16, 2024
@AdnaneKhan
Copy link
Owner Author

Initial work for this completed in #14.

@AdnaneKhan
Copy link
Owner Author

Blocked by #36 as I want to solve this the right way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant