Google Pay improvements #1853
Open
Google Pay improvements #1853
+1,951
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmengelt
reviewed
Oct 29, 2024
googlepay/src/main/java/com/adyen/checkout/googlepay/GooglePayComponent.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Oct 29, 2024
OscarSpruit
force-pushed
the
feature/google-pay
branch
2 times, most recently
from
d47c46a
to
b47ba4f
Compare
COAND-855
COAND-855
COAND-855
COAND-855
COAND-855
COAND-855
COAND-855
This makes the code interacting with it testable. COAND-855
COAND-855
COAND-855
COAND-855
COAND-942
COAND-942
COAND-942
This is the same as we do with other payment method buttons and makes it easier for merchants to supports dark-mode. It is still be possible for merchants to change this behaviour if they want. COAND-942
COAND-1012
COAND-1012
COAND-1012
COAND-1012
COAND-1012
COAND-1012
COAND-941
This will allow to have customized states. The drawable will now also use it's original color. COAND-943
Exception flow didn't work as the value was only received by one observer. COAND-943
COAND-943
COAND-941
OscarSpruit
force-pushed
the
feature/google-pay
branch
from
380c04e
to
2c30d40
Compare
COAND-944
OscarSpruit
force-pushed
the
feature/google-pay
branch
from
2c30d40
to
afc18b0
Compare
✅ No public API changes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a huge compilation of smaller PRs. These small PRs have all been reviewed.
Checklist
COAND-941