FrontendProxyController.php - change CartOrderRoute to AbstractCartOrderRoute

[sascha-seyfert]

Hello dear Adyen team,

There is a bug in the Adyen Shopware 6 plugin.

This error occurs in connection with a third-party plugin.

Name of the third-party plugin: Conversion Checkout for Shopware 6
Store: https://store.shopware.com/en/loyxx57434896565m/conversion-checkout-for-shopware-6.html

Description of the problem / clear instructions for reproduction:

[2024-02-09T08:06:36.056488+00:00] request.CRITICAL: Uncaught PHP Exception TypeError: "Cannot assign LoyxxSW6ConversionCheckout\Core\Checkout\Cart\SalesChannel\CartOrderRoute to property Adyen\Shopware\Storefront\Controller\FrontendProxyController: :$cartOrderRoute of type Shopware\Core\Checkout\Cart\SalesChannel\CartOrderRoute" at FrontendProxyController.php line 71 {"exception":"[object] (TypeError(code: 0): Cannot assign LoyxxSW6ConversionCheckout\Core\Checkout\ \Cart\SalesChannel\CartOrderRoute to property Adyen\Shopware\Storefront\Controller\FrontendProxyController::$cartOrderRoute of type Shopware\Core\Checkout\Cart\SalesChannel\CartOrderRoute at /var/www /clients/client1/web2/web/production/releases/193/vendor/adyen/adyen-shopware6/src/Storefront/Controller/FrontendProxyController.php:71)"} []

PHP class:
Adyen\Shopware\Storefront\Controller\FrontendProxyController

Change:

• private CartOrderRoute $cartOrderRoute;

• private AbstractCartOrderRoute $cartOrderRoute;

adyen-shopware6/src/Storefront/Controller/FrontendProxyController.php

Line 54 in a8a59eb

private CartOrderRoute $cartOrderRoute;

[RokPopov]

Hi @sascha-seyfert,

Thank you for reporting this issue. I have created an internal ticket for handling this. Once the fix is merged with the develop branch, this issue will automatically be closed.

Kind regards,
Rok

[MelvinAchterhuis]

@RokPopov , same goes for PostNL:

Cannot assign PostNL\Shopware6\Controller\StoreApi\ContextSwitchRoute to property Adyen\Shopware\Storefront\Controller\FrontendProxyController::$contextSwitchRoute of type Shopware\Core\System\SalesChannel\SalesChannel\ContextSwitchRoute

See: https://github.com/Adyen/adyen-shopware6/pull/499/files

[AndreasA]

It seems like this was fixed with 4.0.0
https://github.com/Adyen/adyen-shopware6/blob/4.0.0/src/Storefront/Controller/FrontendProxyController.php

but not with 3.16.0 https://github.com/Adyen/adyen-shopware6/blob/3.16.0/src/Storefront/Controller/FrontendProxyController.php

which means that for 6.5 which is the LTS version already the fix is not available.

[rick7240]

@RokPopov The problem was fixed in the 4.X version, but not in the 3.X version. Due to the Shopware Version not everyone can update to the 4.X version and is dependent on a bugfix in the 3.X version.

We now have to downgrade to a previous 3.X version. Actually we need the 3.16.1 but because of the ECP-9382-v3 Visa Compliance issue.

Can THIS bug also be fixed in the 3.X version in the short term?