-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds a formatter support for Ruff, two commands and related settings. Updates the config to handle workspace and global boolean settings. Resolves #3.
- Loading branch information
Showing
4 changed files
with
195 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| class Formatter { | ||
| constructor(config) { | ||
| this.config = config; | ||
| } | ||
|
|
||
| async getProcess(filename = null) { | ||
| const executablePath = nova.path.expanduser(this.config.get("executablePath")); | ||
| const commandArguments = this.config.get("commandFormatArguments"); | ||
| const defaultOptions = (filename) | ||
| ? (filename !== ".") | ||
| ? ["--quiet", `--stdin-filename=${filename}`, "-"] | ||
| : ["--quiet", filename] | ||
| : ["--quiet", "-"]; | ||
|
|
||
| if (!nova.fs.stat(executablePath)) { | ||
| console.error(`Executable ${executablePath} does not exist`); | ||
| return; | ||
| } | ||
|
|
||
| var options = []; | ||
|
|
||
| if (commandArguments) { | ||
| options = commandArguments | ||
| .replaceAll("\n", " ") | ||
| .split(" ") | ||
| .map((option) => option.trim()) | ||
| .filter((option) => option !== " "); | ||
| } | ||
|
|
||
| options = [...options, ...defaultOptions].filter((option) => option !== ""); | ||
|
|
||
| return new Process( | ||
| executablePath, | ||
| { | ||
| args: ["format", ...Array.from(new Set(options))], | ||
| stdio: "pipe", | ||
| cwd: nova.workspace.path, // NOTE: must be explicitly set | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| async getPromiseToFormat(editor) { | ||
| if (!this.config.get("formatOnSave")) return; | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| this.format(editor, resolve, reject); | ||
| }); | ||
| } | ||
|
|
||
| async format(editor, resolve=null, reject=null) { | ||
| if (editor.document.isEmpty) { | ||
| if (reject) reject("empty file"); | ||
| return; | ||
| } | ||
|
|
||
| let process = await this.getProcess( | ||
| editor.document.path ? nova.path.basename(editor.document.path) : null | ||
| ); | ||
|
|
||
| if (!process) { | ||
| if (reject) reject("no process"); | ||
| return; | ||
| } | ||
|
|
||
| const textRange = new Range(0, editor.document.length); | ||
| const content = editor.document.getTextInRange(textRange); | ||
| const filePath = nova.workspace.relativizePath(editor.document.path); | ||
|
|
||
| let outBuffer = []; | ||
| let errBuffer = []; | ||
|
|
||
| process.onStdout((output) => outBuffer.push(output)); | ||
| process.onStderr((error) => errBuffer.push(error)); | ||
| process.onDidExit((status) => { | ||
| if (status === 0) { | ||
| const formattedContent = outBuffer.join(""); | ||
|
|
||
| let result = editor.edit((edit) => { | ||
| if (formattedContent !== content) { | ||
| console.log("Formatting " + filePath); | ||
| edit.replace(textRange, formattedContent, InsertTextFormat.PlainText); | ||
| } else { | ||
| console.log("Nothing to format"); | ||
| } | ||
| }); | ||
|
|
||
| if (resolve) resolve(result); | ||
| } else { | ||
| console.error(errBuffer.join("")); | ||
| if (reject) reject(); | ||
| } | ||
| }); | ||
|
|
||
| console.log("Running " + process.command + " " + process.args.join(" ")); | ||
|
|
||
| process.start(); | ||
|
|
||
| let writer = process.stdin.getWriter(); | ||
|
|
||
| writer.ready.then(() => { | ||
| writer.write(content); | ||
| writer.close(); | ||
| }); | ||
| } | ||
|
|
||
| async formatWorkspace(workspace) { | ||
| let process = await this.getProcess("."); | ||
|
|
||
| if (!process) { | ||
| return; | ||
| } | ||
|
|
||
| let errBuffer = []; | ||
|
|
||
| process.onStderr((error) => errBuffer.push(error)); | ||
| process.onDidExit((status) => { | ||
| if (status === 0) { | ||
| console.log("Formatting the workspace"); | ||
| } else { | ||
| console.error(errBuffer.join("")); | ||
| } | ||
| }); | ||
|
|
||
| console.log("Running " + process.command + " " + process.args.join(" ")); | ||
|
|
||
| process.start(); | ||
| } | ||
| } | ||
|
|
||
| module.exports = Formatter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters