Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moss: Explore making moss state verify able to use multiple threads when verifying #390

Open
ermo opened this issue Jan 6, 2025 · 1 comment · May be fixed by #421
Open

moss: Explore making moss state verify able to use multiple threads when verifying #390

ermo opened this issue Jan 6, 2025 · 1 comment · May be fixed by #421
Assignees
@jplatte @tarkah
Labels
type: enhancement New feature or request

Comments

@ermo
Copy link
Contributor

ermo commented Jan 6, 2025 •
edited
Loading

Currently, it looks like moss is stuck verifying on a single core at a time.

Perhaps it would be fruitful in a performance sense to parallelize this feature?
@ermo ermo added the type: enhancement New feature or request label Jan 6, 2025
@joebonrichie
Copy link
Contributor

The most obvious solution would be to use rayon but it is incompatible with the itertools functions currently used i.e. .into_group_map()

joebonrichie added a commit that referenced this issue Feb 10, 2025
@joebonrichie
moss: parallelize 'state verify'
4aea0c0 
Use rayon to iterate over entries in parallel and use a Arc<Rwlock<>> to
update the vec of issues atomically.

Resolves #390.
@joebonrichie joebonrichie linked a pull request Feb 10, 2025 that will close this issue
Draft
joebonrichie added a commit that referenced this issue Feb 10, 2025
@joebonrichie
moss: parallelize 'state verify'
fee7e19 
Use rayon to iterate over entries in parallel and use a Arc<Rwlock<>> to
update the vec of issues atomically.

Resolves #390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jplatte jplatte

@tarkah tarkah

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

moss: parallelize 'state verify' AerynOS/os-tools
4 participants
@ermo @jplatte @joebonrichie @tarkah