Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODOs in Swahili Demographic Cleaner #31

Open
as2388 opened this issue Jul 17, 2018 · 1 comment
Open

Address TODOs in Swahili Demographic Cleaner #31

as2388 opened this issue Jul 17, 2018 · 1 comment

Comments

@as2388
Copy link
Member

as2388 commented Jul 17, 2018

core_data_modules.cleaners.swahili.demographic_cleaners.py and its associated unit tests file both still have some TODOS which need addressing.

This includes questions over the return type of some of the functions and whether cleaners should work on single-digit numbers rather than just double-digit numbers.
@as2388 as2388 mentioned this issue Jul 26, 2018
Merged
@as2388
Copy link
Member Author

as2388 commented Jul 26, 2018

Also need to look in core_data_modules.regex_utils.py now that clean_with_pattern moved to here due to #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@as2388