misc Fast USDC improvements #11049
Merged
misc Fast USDC improvements #11049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1477c17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4164afd7.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-fu-misc.agoric-sdk.pages.dev |
|
Dropping this to draft because forgoing |
dckc
reviewed
Feb 26, 2025
dckc
approved these changes
Feb 27, 2025
Comment on lines
+220
to
+222
| lastEvidence, | ||
| '!=', | ||
| next, |
There was a problem hiding this comment.
do we have the operator ids handy at this point?
It would be nice to know which evidence comes from which operator.
I think it's not hard to find from a few earlier log messages, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Mostly extracted from #11025
encodingfrom ChainAddress because it broke contract upgrade,Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI suffices
Upgrade Considerations
No upgrade test yet. #11025 has that and is in flight.