Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No keyboard usage for accessibility #339

Open
willsmanley opened this issue Jan 6, 2025 · 5 comments · May be fixed by #340
Open

No keyboard usage for accessibility #339

willsmanley opened this issue Jan 6, 2025 · 5 comments · May be fixed by #340
Labels
guidance Question that needs advice or information.

Comments

@willsmanley
Copy link

On web builds, it is impossible to navigate the dropdown options using the arrow keys.

This is present in material's dropdown button, but not this implementation.

It should work the same as an HTML <select> where you can focus into the dropdown with tab + space (which works) and then navigate between the options with arrow and select an option with space (which is not yet implemented).

This probably isn't too hard to do, I will take a look if I can solve it in a fork and put up a PR if its good.

@AhmedLSayed9
Copy link
Owner

If the selectedValue is null and you open the dropdown:

  • In material's DropdownButton, the first item is selected.
  • in DropdownButton2, no item will be selected (sound's reasonable to me) and you should press tab to start selecting an item.
Screen.Recording.2025-01-18.at.6.49.44.AM.mov

If there's a selectedValue and you open the dropdown, the item will be selected at both materials's DropdownButton and DropdownButton2:

Screen.Recording.2025-01-18.at.6.50.16.AM.mov

@AhmedLSayed9 AhmedLSayed9 added the guidance Question that needs advice or information. label Jan 18, 2025
@willsmanley
Copy link
Author

I think the PR that I mentioned above is required for this to work (at least on the older API, I can't remember right now but I think there was some kind of recent API change. Maybe this only applies to the version I checked out there?)

@willsmanley
Copy link
Author

Ah yeah here's my comment about it: #340 (comment)

@AhmedLSayed9
Copy link
Owner

The current version 3.0.0-beta.21 is safe to be used. Actually, it has some other important fixes.

Your PR fixes the issue on the stable release but introduces another issue (as commented above the line you've remove).

If you need to fix this on the stable release, you should apply the following commits:
9a5116d
d073640

@AhmedLSayed9
Copy link
Owner

AhmedLSayed9 commented Jan 18, 2025

The beta version is just not released because I'm trying to implement the pagination feature before publishing version 3, which may require new apis and other breaking changes. But meh, I haven't found the time yet. I might just release it soon and postpone the pagination feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
2 participants