Skip to content

Split OnObtainAllSkillsShuffleItem #411

Split OnObtainAllSkillsShuffleItem

Split OnObtainAllSkillsShuffleItem #411

Triggered via pull request April 27, 2024 18:51
Status Success
Total duration 38s
Artifacts

build.yml

on: pull_request
Build
30s
Build
Check clippy lints
27s
Check clippy lints
Check formatting
3s
Check formatting
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
Check formatting: src/auto_splitter_settings.rs#L8
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L56
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L63
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L85
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L97
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L104
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L115
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/auto_splitter_settings.rs#L136
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
Check formatting: src/file.rs#L1
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/file.rs
Check formatting: src/hollow_knight_memory.rs#L1
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/hollow_knight_memory.rs
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check clippy lints
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check clippy lints: src/hollow_knight_memory.rs#L1142
this `else { if .. }` block can be collapsed
Check clippy lints: src/hollow_knight_memory.rs#L2715
using `clone` on type `bool` which implements the `Copy` trait
Check clippy lints: src/hollow_knight_memory.rs#L2718
using `clone` on type `bool` which implements the `Copy` trait
Check clippy lints: src/hollow_knight_memory.rs#L2797
using `clone` on type `bool` which implements the `Copy` trait
Check clippy lints: src/hollow_knight_memory.rs#L2800
using `clone` on type `bool` which implements the `Copy` trait
Check clippy lints: src/hollow_knight_memory.rs#L3448
this boolean expression can be simplified
Check clippy lints: src/hollow_knight_memory.rs#L3566
this boolean expression can be simplified
Check clippy lints: src/hollow_knight_memory.rs#L3568
this boolean expression can be simplified
Check clippy lints: src/hollow_knight_memory.rs#L3569
unnecessary use of `to_vec`
Check clippy lints: src/hollow_knight_memory.rs#L3629
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.