[AAE-30886] - Upgrade to latest editorjs #10672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitoAlbano
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
VitoAlbano
force-pushed
the
improvement/AAE-30886-latest-editor-js
branch
from
f0e9ae8 to
2477a8c
Compare
ehsan-2019
reviewed
Feb 25, 2025
| @@ -78,6 +78,6 @@ export class DisplayRichTextWidgetComponent extends WidgetComponent implements O | |||
| } | |||
|
|
|||
| private sanitizeHtmlContent(): void { | |||
| this.parsedHTML = this.sanitizer.sanitize(SecurityContext.HTML, this.parsedHTML.join('')); | |||
There was a problem hiding this comment.
join was not needed anymore?
There was a problem hiding this comment.
no the result are now already formatted (I haven't changed the unit test to check the result) so I expect it will be fine
ehsan-2019
approved these changes
Feb 25, 2025
VitoAlbano
force-pushed
the
improvement/AAE-30886-latest-editor-js
branch
from
a1e663d to
8c147b3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: