Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_manifold_like #229

Closed
wants to merge 1 commit into from
Closed

Use is_manifold_like #229

wants to merge 1 commit into from

Conversation

lukem12345
Copy link
Member

Close #228

@lukem12345 lukem12345 added the enhancement New feature or request label May 17, 2024
@lukem12345 lukem12345 self-assigned this May 17, 2024
@jpfairbanks
Copy link
Member

Should we check this on creating the Dual mesh rather than on simulation, for performance?

Design Rationale:

  1. We don't want to enforce that all SimplicialSets are manifold-like because you could use CombinatorialSpaces for TDA or another usage of simplicial sets that does work for Abstract Simplicial Complexes. So we can't do this check in the constructor for the primal mesh.
  2. We do want to check manifoldness of the mesh before we simulate
  3. We only want to check it once per mesh
  4. The heat equation doesn't require the mesh to be manifold-like so you should be able to simulate without this check if the equations are simple enough.
  5. All of the physics that use the dual mesh will break if the primal mesh is not a valid triangulation of a manifold.

@lukem12345 lukem12345 closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use is_manifold_like
2 participants