Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default expression editor is new one for all apps #11739

Closed
3 tasks done
Tracked by #11634
nkylstad opened this issue Nov 30, 2023 · 2 comments · Fixed by #11914
Closed
3 tasks done
Tracked by #11634

Default expression editor is new one for all apps #11739

nkylstad opened this issue Nov 30, 2023 · 2 comments · Fixed by #11914

Comments

@nkylstad
Copy link
Member

nkylstad commented Nov 30, 2023 •
edited by standeren
Loading

Description

  • Should be possible to toggle old dynamics setup for apps with RuleHandler.js
  • Move state of which dynamics version (new/old) should be shown in to the component, instead of feature flag.

Checking if the app has the RuleHandler.js file could f.ex. be done by checking if the window.RuleHandlerObject exists.

Tasks
Preview Give feedback
@nkylstad nkylstad mentioned this issue Nov 30, 2023
Closed
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Dec 19, 2023
@nkylstad nkylstad mentioned this issue Dec 19, 2023
Closed
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 22, 2023
@standeren standeren self-assigned this Dec 22, 2023
@standeren standeren linked a pull request Dec 22, 2023 that will close this issue
Only show switch to edit old dynamics if app has rulehandler #11914
Merged
3 tasks
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 23, 2023
@standeren standeren removed their assignment Dec 23, 2023
@TomasEng TomasEng self-assigned this Jan 2, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jan 3, 2024
@TomasEng TomasEng assigned TomasEng and unassigned TomasEng Jan 4, 2024
@TomasEng
Copy link
Contributor

TomasEng commented Jan 4, 2024

Testet OK.

@TomasEng TomasEng moved this from 🧪 Test to ✅ Done in Team Studio Jan 4, 2024
@framitdavid
Copy link
Collaborator

Nice work! Tested OK in dev.

@TomasEng TomasEng removed their assignment Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show switch to edit old dynamics if app has rulehandler Altinn/altinn-studio
4 participants
@nkylstad @TomasEng @framitdavid @standeren