Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show switch to edit old dynamics if app has rulehandler #11914

Merged

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 22, 2023

Description

  • Move logic to switch between old and new dynamics to new dynamics component
  • Use a regular state that does not involve feature flags
  • Remove expressions as a feature
  • Make default selected dynamics editor as new expressions
  • Only show switch to use old dynamics if app has rulehandler file

NB

Need to delete the ruleHandlerObject from the window object. The window object will remember that the ruleHandler was fetched from another layoutset when switching to a layoutset that does not have the ruleHandler ⚠️

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Dec 22, 2023 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 22, 2023
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from 0a0f720 to 83127b2 Compare December 22, 2023 12:46
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from 8a1accb to ad85e53 Compare December 22, 2023 16:56
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from ad85e53 to d744635 Compare December 22, 2023 17:05
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from d744635 to 71ac709 Compare December 23, 2023 09:19
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1000e5d) 86.97% compared to head (592c87a) 86.90%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11914      +/-   ##
==========================================
- Coverage   86.97%   86.90%   -0.07%     
==========================================
  Files         927      928       +1     
  Lines       13146    13161      +15     
  Branches     1599     1604       +5     
==========================================
+ Hits        11434    11438       +4     
- Misses       1491     1507      +16     
+ Partials      221      216       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren marked this pull request as ready for review December 27, 2023 07:44
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from 4c0276d to 7ac84d0 Compare January 2, 2024 12:48
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from acf91c1 to f32344f Compare January 3, 2024 08:49
@standeren standeren force-pushed the 11739-default-expression-editor-is-new-one-for-all-apps branch from 069301e to 592c87a Compare January 3, 2024 11:37
@standeren standeren merged commit 97bab35 into master Jan 3, 2024
10 of 11 checks passed
@standeren standeren deleted the 11739-default-expression-editor-is-new-one-for-all-apps branch January 3, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default expression editor is new one for all apps
2 participants