-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show switch to edit old dynamics if app has rulehandler #11914
Merged
standeren
merged 7 commits into
master
from
11739-default-expression-editor-is-new-one-for-all-apps
Jan 3, 2024
Merged
Only show switch to edit old dynamics if app has rulehandler #11914
standeren
merged 7 commits into
master
from
11739-default-expression-editor-is-new-one-for-all-apps
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a0f720
to
83127b2
Compare
frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx
Fixed
Show fixed
Hide fixed
8a1accb
to
ad85e53
Compare
ad85e53
to
d744635
Compare
d744635
to
71ac709
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11914 +/- ##
==========================================
- Coverage 86.97% 86.90% -0.07%
==========================================
Files 927 928 +1
Lines 13146 13161 +15
Branches 1599 1604 +5
==========================================
+ Hits 11434 11438 +4
- Misses 1491 1507 +16
+ Partials 221 216 -5 ☔ View full report in Codecov by Sentry. |
TomasEng
approved these changes
Jan 2, 2024
Co-authored-by: Tomas Engebretsen <[email protected]>
…dler is fetched from backend
4c0276d
to
7ac84d0
Compare
acf91c1
to
f32344f
Compare
069301e
to
592c87a
Compare
TomasEng
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ui-editor
Area: Related to the designer tool for assembling app UI in Altinn Studio.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NB
Need to delete the ruleHandlerObject from the window object. The window object will remember that the ruleHandler was fetched from another layoutset when switching to a layoutset that does not have the ruleHandler⚠️
Verification