Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchpattern when fetching languages from files in text directory #11915

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 23, 2023

Description

Add searchpattern when fetching files to figure out what languages the resource files are available in.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Dec 23, 2023 that may be closed by this pull request
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Dec 23, 2023
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f835d2) 86.97% compared to head (0a49764) 86.97%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11915   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         927      927           
  Lines       13146    13146           
  Branches     1599     1599           
=======================================
  Hits        11434    11434           
  Misses       1491     1491           
  Partials      221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren changed the title Add regex when fetching languages from files in text directory Add searchpattern when fetching languages from files in text directory Dec 28, 2023
@standeren standeren merged commit 937848d into master Dec 29, 2023
16 checks passed
@standeren standeren deleted the 11869-allow-other-files-than-text-resources-in-configtexts-folder branch December 29, 2023 06:41
standeren added a commit that referenced this pull request Dec 29, 2023
#11915)

* Add regex when fetching languages from files in text directory

* add test

* Use inbuilt searchpattern in Directory.GetFiles() instead of regEx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow other files than text-resources in config/texts folder
2 participants