-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add searchpattern when fetching languages from files in text directory #11915
Merged
standeren
merged 5 commits into
master
from
11869-allow-other-files-than-text-resources-in-configtexts-folder
Dec 29, 2023
Merged
Add searchpattern when fetching languages from files in text directory #11915
standeren
merged 5 commits into
master
from
11869-allow-other-files-than-text-resources-in-configtexts-folder
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-in-configtexts-folder
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11915 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 927 927
Lines 13146 13146
Branches 1599 1599
=======================================
Hits 11434 11434
Misses 1491 1491
Partials 221 221 ☔ View full report in Codecov by Sentry. |
mirkoSekulic
requested changes
Dec 27, 2023
backend/src/Designer/Infrastructure/GitRepository/AltinnAppGitRepository.cs
Outdated
Show resolved
Hide resolved
mirkoSekulic
approved these changes
Dec 28, 2023
…s-in-configtexts-folder
standeren
added a commit
that referenced
this pull request
Dec 29, 2023
#11915) * Add regex when fetching languages from files in text directory * add test * Use inbuilt searchpattern in Directory.GetFiles() instead of regEx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
quality/testing
Tests that are missing, needs to be created or could be improved.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add searchpattern when fetching files to figure out what languages the resource files are available in.
Verification