Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceadm: change available fields for resource type "MaskinportenSchema" #11933

Merged
merged 32 commits into from
Jan 8, 2024

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Jan 2, 2024

Description

When resourceType is "MaskinportenSchema", the following fields are removed:

  • Selvidentifisert bruker
  • Enterprise bruker
  • Parter som kan bruke tjenesten

A field to add one or more resource references is added. The contact points field is refactored to allow for a more generic list-based field with a set of fields.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Jan 2, 2024
@mgunnerud mgunnerud requested a review from a user January 2, 2024 14:12
@ghost
Copy link

ghost commented Jan 4, 2024

@mgunnerud ser ut som at typene feiler etter siste oppdatering av designsystemet?
Virker som det er Select komponenten som er fjernet fra pakken, ref dette. Anbefaler at du bare endrer til LegacySelect i denne PRen, også lage en ny issue og PR der du endrer fra legacy til ny komponent 😄

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4513312) 86.96% compared to head (5a493ac) 86.96%.

Files Patch % Lines
...eadm/pages/AboutResourcePage/AboutResourcePage.tsx 63.63% 8 Missing ⚠️
...nd/resourceadm/pages/ResourcePage/ResourcePage.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11933      +/-   ##
==========================================
- Coverage   86.96%   86.96%   -0.01%     
==========================================
  Files         934      938       +4     
  Lines       13323    13347      +24     
  Branches     1634     1637       +3     
==========================================
+ Hits        11587    11607      +20     
- Misses       1519     1524       +5     
+ Partials      217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added a few comments for consideration 😄

@mgunnerud mgunnerud merged commit 350fed5 into master Jan 8, 2024
9 of 10 checks passed
@mgunnerud mgunnerud deleted the 11905-part2 branch January 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resourceadm: Change available fields for resource type "Maskinporten skjema"
1 participant