refactor(pages-api): implement new page re-ordering on frontend #14717

Jondyr · 2025-02-19T08:26:16Z

Description

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Related Issue(s)

Create CRUD endpoints for pages/groups #14582

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

coderabbitai · 2025-02-19T08:26:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

commit-id:d90419ee

codecov · 2025-02-21T08:56:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (ddd634d) to head (2c0ec98).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           spr/main/1a231f84   #14717      +/-   ##
=====================================================
- Coverage              95.78%   95.77%   -0.01%     
=====================================================
  Files                   1927     1927              
  Lines                  25126    25127       +1     
  Branches                2868     2865       -3     
=====================================================
  Hits                   24066    24066              
- Misses                   800      801       +1     
  Partials                 260      260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lassopicasso

Well done 💪

lassopicasso · 2025-02-25T14:00:19Z

...packages/ux-editor/src/containers/DesignView/PageAccordion/NavigationMenu/NavigationMenu.tsx

+  const pageIndex = pagesModel.pages.findIndex((page) => page.id === pageName);
+  const disableUp = pageIndex === 0;
+  const disableDown = pageIndex === pagesModel.pages.length - 1;


Nice adjustments on the disable logic, easier to read :)

lassopicasso · 2025-02-25T14:03:10Z

...packages/ux-editor/src/containers/DesignView/PageAccordion/NavigationMenu/NavigationMenu.tsx


-  const { mutate: updateLayoutOrder } = useUpdateLayoutOrderMutation(


It seems like this hook was only used here. Perhaps we can fully remove the hook as well? 🙂

Nice catch, removed 👍

lassopicasso

🎉

mlqn · 2025-02-26T15:35:10Z

Fantastic job! 🤩 I tested in DEV and noticed a few issues :

When I add a new page :

The navigation buttons are missing
The new page is not automatically selected
The new page does not open when I click on it

add-pages.mov

When I edit or delete a page name, the selected page remains the old one (url + config panel)

edit-pages.mov

delete-pages.mov

An error occurs when double-clicking the `Legg til ny side` button

double-click-pages.mov

This will configure a page layout and allow optional additions to be made through a builder pattern.

Jondyr · 2025-02-27T09:28:30Z

@mlqn
Thanks for the detailed testing and feedback! 💪
I've addressed these, and they should be working now:

The navigation buttons are missing
The new page is not automatically selected
The new page does not open when I click on it

But i was unable to reproduce the double click issue, maybe it was solved by the changes done. Please take a look.

github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Feb 19, 2025

Jondyr force-pushed the spr/main/d90419ee branch 2 times, most recently from 3dd2f72 to bde0916 Compare February 19, 2025 08:41

Jondyr added the team/studio-domain2 label Feb 19, 2025

Jondyr force-pushed the spr/main/d90419ee branch 6 times, most recently from b951e77 to a9fa3e6 Compare February 21, 2025 08:34

refactor(pages-api): implement new page re-ordering on frontend

cb47f31

commit-id:d90419ee

Jondyr force-pushed the spr/main/d90419ee branch from a9fa3e6 to cb47f31 Compare February 21, 2025 08:34

Jondyr added 2 commits February 25, 2025 11:53

Merge branch 'spr/main/1a231f84' into spr/main/d90419ee

3b7ff50

Merge branch 'spr/main/1a231f84' into spr/main/d90419ee

04d611d

lassopicasso self-assigned this Feb 25, 2025

style: fix formatting

e33282d

lassopicasso reviewed Feb 25, 2025

View reviewed changes

lassopicasso assigned Jondyr and unassigned lassopicasso Feb 25, 2025

Jondyr linked an issue Feb 26, 2025 that may be closed by this pull request

Create CRUD endpoints for pages/groups #14582

Open

4 tasks

Jondyr mentioned this pull request Feb 13, 2025

Create CRUD endpoints for pages/groups #14582

Open

4 tasks

chore: remove unused hook

59dc62e

Jondyr assigned lassopicasso and unassigned Jondyr Feb 26, 2025

lassopicasso approved these changes Feb 26, 2025

View reviewed changes

lassopicasso removed their assignment Feb 26, 2025

mlqn temporarily deployed to dev February 26, 2025 14:53 — with GitHub Actions Inactive

mlqn temporarily deployed to dev February 26, 2025 14:54 — with GitHub Actions Inactive

mlqn temporarily deployed to dev February 26, 2025 15:02 — with GitHub Actions Inactive

fix: add AltinnPageLayout builder

082b327

This will configure a page layout and allow optional additions to be made through a builder pattern.

github-actions bot added the backend label Feb 27, 2025

Jondyr added 2 commits February 27, 2025 10:10

fix: don't add navigation buttons for first page

d7e9752

fix: invalidate formlayoutsettings and set new page as selected

d19b4c4

Jondyr added 2 commits February 27, 2025 10:49

fix: add optional chaining

c5fcd55

Merge branch 'spr/main/1a231f84' into spr/main/d90419ee

2c0ec98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(pages-api): implement new page re-ordering on frontend #14717

refactor(pages-api): implement new page re-ordering on frontend #14717

Jondyr commented Feb 19, 2025 •

edited

Loading

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Feb 21, 2025 •

edited

Loading

lassopicasso left a comment •

edited

Loading

lassopicasso Feb 25, 2025

lassopicasso Feb 25, 2025

Jondyr Feb 26, 2025

lassopicasso left a comment

mlqn commented Feb 26, 2025 •

edited

Loading

Jondyr commented Feb 27, 2025


		const { mutate: updateLayoutOrder } = useUpdateLayoutOrderMutation(

refactor(pages-api): implement new page re-ordering on frontend #14717

Are you sure you want to change the base?

refactor(pages-api): implement new page re-ordering on frontend #14717

Conversation

Jondyr commented Feb 19, 2025 • edited Loading

Description

Related Issue(s)

Verification

Documentation

coderabbitai bot commented Feb 19, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Feb 21, 2025 • edited Loading

Codecov Report

lassopicasso left a comment • edited Loading

Choose a reason for hiding this comment

lassopicasso Feb 25, 2025

Choose a reason for hiding this comment

lassopicasso Feb 25, 2025

Choose a reason for hiding this comment

Jondyr Feb 26, 2025

Choose a reason for hiding this comment

lassopicasso left a comment

Choose a reason for hiding this comment

mlqn commented Feb 26, 2025 • edited Loading

When I add a new page :

When I edit or delete a page name, the selected page remains the old one (url + config panel)

An error occurs when double-clicking the Legg til ny side button

Jondyr commented Feb 27, 2025

Jondyr commented Feb 19, 2025 •

edited

Loading

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 21, 2025 •

edited

Loading

lassopicasso left a comment •

edited

Loading

mlqn commented Feb 26, 2025 •

edited

Loading

An error occurs when double-clicking the `Legg til ny side` button