test: 14609 - playwright test for adding adding a row and editing a codelist for org #14807

wrt95 · 2025-02-25T16:54:46Z

Description

Playwright test for adding adding a row and editing a codelist for org

Related Issue(s)

Playwright tests for org library #14609

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)

coderabbitai · 2025-02-25T16:54:53Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-25T17:05:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (c088b24) to head (86286e8).
Report is 4 commits behind head on org-library-mvp.

Additional details and impacted files

@@               Coverage Diff                @@
##           org-library-mvp   #14807   +/-   ##
================================================
  Coverage            95.79%   95.79%           
================================================
  Files                 1936     1936           
  Lines                25245    25245           
  Branches              2859     2859           
================================================
  Hits                 24184    24184           
  Misses                 800      800           
  Partials               261      261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TomasEng

Jeg har noen forslag til navngivning av diverse ting i denne PR-en. Det er viktig for å oppnå en kode som sier presist hva den gjør samtidig som den kommuniserer intensjonen bak funksjonene. La meg få vite hva du tenker.

frontend/testing/playwright/pages/OrgLibraryPage/CodeLists.ts

frontend/testing/playwright/tests/org-library/codelists.spec.ts

frontend/testing/playwright/pages/OrgLibraryPage/CodeLists.ts

TomasEng

Nå synes jeg det ble mye bedre! Oppdaget bare noen små følgefeil.

TomasEng · 2025-02-27T12:56:18Z

frontend/testing/playwright/pages/OrgLibraryPage/CodeLists.ts

+  public async verifyEmptyLabelTextfield(itemNumber: number): Promise<void> {
+    const textfield = this.page.getByRole('textbox', {
+      name: this.textMock('code_list_editor.value_item', { number: itemNumber.toString() }),
+      exact: true,
+    });
+
+    await expect(textfield).toHaveValue('');
+  }


Suggested change

public async verifyEmptyLabelTextfield(itemNumber: number): Promise<void> {

const textfield = this.page.getByRole('textbox', {

name: this.textMock('code_list_editor.value_item', { number: itemNumber.toString() }),

exact: true,

});

await expect(textfield).toHaveValue('');

}

public async verifyEmptyLabelTextfield(itemNumber: number): Promise<void> {

await this.verifyLabelTextfield(itemNumber, '');

}

TomasEng · 2025-02-27T12:58:20Z

frontend/testing/playwright/pages/OrgLibraryPage/CodeLists.ts

-      })
-      .click();
+  public async verifyEmptyValueTextfield(itemNumber: number): Promise<void> {
+    this.verifyValueTextfield(itemNumber, '');


Denne tar jeg på min kappe siden det var mitt forslag. Vi bør ha med await foran.

Suggested change

this.verifyValueTextfield(itemNumber, '');

await this.verifyValueTextfield(itemNumber, '');

TomasEng · 2025-02-27T12:59:32Z

frontend/testing/playwright/tests/org-library/codelists.spec.ts

@@ -10,7 +10,9 @@ const TEST_ORG: string = 'ttd';
 const CODELIST_TITLE_MANUALLY: string = 'Test_codelist';
 const CODELIST_TITLE_UPLOADED: string = 'testCodelist';

-const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST: number = 1;
+const EXPECTED_NUMBER_OF_ITEMS_IN_MANUALLY_CREATED_CODELIST: number = 1;
+const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW: number =


Suggested change

const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW: number =

const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW: number =

TomasEng · 2025-02-27T13:01:22Z

frontend/testing/playwright/tests/org-library/codelists.spec.ts

+
+  await orgLibraryPage.codeLists.clickOnAddItemButton();
+  await orgLibraryPage.codeLists.verifyNumberOfItemsInTheCodelist(
+    EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW,


Suggested change

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW,

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW,

TomasEng · 2025-02-27T13:01:31Z

frontend/testing/playwright/tests/org-library/codelists.spec.ts

+  );
+
+  const lastlyAddedItemNumber: number =
+    EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW;


Suggested change

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW;

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW;

TomasEng · 2025-02-27T13:01:53Z

frontend/testing/playwright/tests/org-library/codelists.spec.ts

@@ -91,7 +127,7 @@ test('that it is possible to search for and delete the new codelists', async ({
  await deleteAndVerifyDeletionOfCodeList(
    orgLibraryPage,
    CODELIST_TITLE_MANUALLY,
-    EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST,
+    EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW,


Suggested change

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW,

EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW,

frontend/testing/playwright/pages/OrgLibraryPage/CodeLists.ts

implementing test for edit codelist

75cbfea

wrt95 added the team/studio-domain1 label Feb 25, 2025

github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. frontend labels Feb 25, 2025

wrt95 mentioned this pull request Feb 25, 2025

Playwright tests for org library #14609

Open

9 tasks

wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Feb 26, 2025

github-actions bot approved these changes Feb 26, 2025

View reviewed changes

wrt95 added 4 commits February 26, 2025 15:16

merge base and update tests

d1440f7

solve merge conflict

7cc80df

rename file

ab1757d

fixing test

28d73a1

wrt95 mentioned this pull request Feb 27, 2025

Test/14609/playwright test for delete row in codelist #14829

Draft

3 tasks

TomasEng self-assigned this Feb 27, 2025

TomasEng requested changes Feb 27, 2025

View reviewed changes

fixing comments from PR2

813176a

wrt95 requested a review from TomasEng February 27, 2025 12:47

wrt95 assigned wrt95 and unassigned TomasEng Feb 27, 2025

adding config

86286e8

TomasEng reviewed Feb 27, 2025

View reviewed changes

wrt95 assigned TomasEng Feb 27, 2025

wrt95 requested a review from TomasEng February 27, 2025 13:18

wrt95 removed their assignment Feb 27, 2025

fixing comments

6386117

TomasEng approved these changes Feb 27, 2025

View reviewed changes

wrt95 merged commit 945c7c4 into org-library-mvp Feb 27, 2025
6 checks passed

wrt95 deleted the test/14609/playwright-test-for-edit-codelist branch February 27, 2025 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: 14609 - playwright test for adding adding a row and editing a codelist for org #14807

test: 14609 - playwright test for adding adding a row and editing a codelist for org #14807

wrt95 commented Feb 25, 2025

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Feb 25, 2025 •

edited

Loading

TomasEng left a comment

TomasEng left a comment

TomasEng Feb 27, 2025

TomasEng Feb 27, 2025

TomasEng Feb 27, 2025

TomasEng Feb 27, 2025

TomasEng Feb 27, 2025

TomasEng Feb 27, 2025

	this.verifyValueTextfield(itemNumber, '');
	await this.verifyValueTextfield(itemNumber, '');

	const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW: number =
	const EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW: number =

	EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CODELIST_AFTER_ADDING_ROW,
	EXPECTED_NUMBER_OF_ROWS_IN_MANUALLY_CREATED_CODELIST_AFTER_ADDING_ROW,

test: 14609 - playwright test for adding adding a row and editing a codelist for org #14807

test: 14609 - playwright test for adding adding a row and editing a codelist for org #14807

Conversation

wrt95 commented Feb 25, 2025

Description

Related Issue(s)

Verification

coderabbitai bot commented Feb 25, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Feb 25, 2025 • edited Loading

Codecov Report

TomasEng left a comment

Choose a reason for hiding this comment

TomasEng left a comment

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

TomasEng Feb 27, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 25, 2025 •

edited

Loading