Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use DialogContent #1841

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: use DialogContent #1841

merged 1 commit into from
Feb 26, 2025

Conversation

seanes
Copy link
Contributor

@seanes seanes commented Feb 25, 2025 •
edited
Loading

  • Uses Dialog Content in order to encapsulate meta data (sender, recipient, updated date, seen by) and body (summary, main content reference, attachments and gui actions
  • Fixes a couple of bugs found in list view with status and seen by label
  • Fixes a bug with loading in list view
  • tests now have i18n injected when running

Hva er endret?

Related Issue(s)

Dokumentasjon / testdekning

  • Dokumentasjon er oppdatert eller ikke relevant / nødvendig.
  • Det er blitt lagt til nye tester / eksiterende tester er blitt utvidet, eller tester er ikke relevant.

Skjermbilder eller GIFs (valgfritt)

@seanes seanes requested a review from a team as a code owner February 25, 2025 14:12
@seanes seanes marked this pull request as draft February 25, 2025 14:12
@mbacherycz mbacherycz self-requested a review February 25, 2025 14:23
@seanes seanes marked this pull request as ready for review February 25, 2025 20:49
mbacherycz
mbacherycz reviewed Feb 26, 2025
View reviewed changes
packages/frontend/src/api/useDialogs.tsx
export const getSeenByLabel = (
seenBy: SeenByItem[],
t: TFunction<'translation', undefined>,
): { isSeenByEndUser: boolean; seenByOthersCount: number; seenByLabel: string | undefined } => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

mbacherycz
mbacherycz reviewed Feb 26, 2025
View reviewed changes
packages/frontend/tests/setup.ts
@@ -0,0 +1,3 @@
import { i18n } from '../src/i18n/config';

i18n.init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@seanes seanes merged commit 4c16180 into main Feb 26, 2025
22 checks passed
@seanes seanes deleted the fix/dialog_body branch February 26, 2025 04:59
@dialogporten-bot dialogporten-bot mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacherycz mbacherycz mbacherycz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanes @mbacherycz