New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Make all modals dummy components #47

Open

gabrielsaruhashi opened this issue Aug 31, 2020 · 0 comments

Contributor

gabrielsaruhashi commented Aug 31, 2020

so this is also a technical debt that we accumulated, but ideally, our components should never have to access the store.

Ideally this would be passed down from the respective container (index.ts) and all components are dummy.

Sarah took a stab but she was struggling to pass down the function from the container.

This is an example of how I did it on Connect: https://github.com/Ameelio/connect-videoconferencing-client/pull/1/files#diff-c0502a25855c2a8f255cec809139f3f2R42

Let me know what u think!

Originally posted by @gabrielsaruhashi in #44 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment