Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantly crash when add link via share #65

Open
AdityaMH opened this issue Sep 15, 2024 · 3 comments
Open

Instantly crash when add link via share #65

AdityaMH opened this issue Sep 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@AdityaMH
Copy link

AdityaMH commented Sep 15, 2024

Describe the bug
After long time app use, i can't add link to linkhub via share because instantly crashed.

To Reproduce
Steps to reproduce the behavior:

  1. Select link that contain " " or space in address box browser
  2. Share
  3. Crashed

Screenshots

Smartphone (please complete the following information):

  • OS: Android 13
  • Version: 1.6.0

Additional context
Maybe make it pop-up mode to add new link via share like urlchecker can reduce problem like this.

@AdityaMH AdityaMH added the bug Something isn't working label Sep 15, 2024
@AmrDeveloper
Copy link
Owner

Hello @AdityaMH,

Thank you for reporting, can you give me link example to reproduce it with, because it's work find for me on google, amazon, dummy text ...etc

Also you share link from browser or other app

Thank you,

@AdityaMH
Copy link
Author

Any link that include " " or space from any browser even from text editor.
For example "http://google.com/?lang=en GB"

AmrDeveloper added a commit that referenced this issue Sep 16, 2024
@AmrDeveloper
Copy link
Owner

Thank you, it was because space need to be encoded to work well, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants