Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code completion for left side of : #16

Open
Nova38 opened this issue Feb 7, 2025 · 5 comments
Open

Code completion for left side of : #16

Nova38 opened this issue Feb 7, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@Nova38
Copy link

Nova38 commented Feb 7, 2025

Your code completions for the talon list and actions works great and is very useful. I was wondering if there is currently plans to also have tab complete for the non spoken options for the right side of the colin; such as deck(<x>), key(<x>), gamepad(<x>)?

@AndreasArvidsson
Copy link
Owner

Do you mean the left side of the :? Because on the right side is the actions that we already have code completion for.

@AndreasArvidsson AndreasArvidsson added the enhancement New feature or request label Feb 7, 2025
@Nova38
Copy link
Author

Nova38 commented Feb 7, 2025

Ah my bad, yeah I meant the left side.

@AndreasArvidsson AndreasArvidsson changed the title Code Completion for right side of : Code completion for left side of : Feb 7, 2025
@AndreasArvidsson
Copy link
Owner

Got it. It's not something I have planned at the moment but I'm not against it.

@Nova38
Copy link
Author

Nova38 commented Feb 9, 2025

Would you be interested in me potentially contributing on it?

If so I have a few questions:

  • Do we want it to be like the capture syntax auto complete and only have it show up when the user starts typing key etc..
  • Would it be best to have to show up in this order key(->a:->up) where the last key before each of those arrows is used to trigger the next context of what can be auto completed.

@AndreasArvidsson
Copy link
Owner

AndreasArvidsson commented Feb 9, 2025

I would like to say yes, but that code is somewhat complicated and lacking in testing.

Also I don't think you can actually properly complete the keys since they could be combined in any order. We also don't do arguments for actions today.

This would entail detecting that we are on the left hand side. ie the command rule and then have a different completion list compared to if you are on the right hand side. Note that today we only trigger completion on . or manually. Triggering completion on letters is somewhat unusual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants