You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
The line-height property with a value of 1.5 is a good default value, but maybe something opiniated that could be removed, because it will certainly be adjusted according to the design needs.
Another reason is that WordPress (and maybe other tools) allows us to generate some styles from a json file. As these base styles are declared before any other stylesheet, we can't use the generated value for line-height because it will be loaded too early and overloaded.
Would you accept a PR to remove that property?
The text was updated successfully, but these errors were encountered:
I think the line-height of at least 1.5 is designed to meet accessibility standards, especially in the context of blocks of text where the font-size is fairly small. Sure, it's opinionated, but at the same time, it's something that designers really aught to embrace, especially at small font-sizes.
Obviously, line-height: 1.5 isn't going to work for headings, which is why some people are suggesting using line-height: calc(1em + .5rem). This setting satisfies the need for readable text at smaller font-sizes, but also produces tighter leading on headings.
The
line-height
property with a value of1.5
is a good default value, but maybe something opiniated that could be removed, because it will certainly be adjusted according to the design needs.Another reason is that WordPress (and maybe other tools) allows us to generate some styles from a json file. As these base styles are declared before any other stylesheet, we can't use the generated value for
line-height
because it will be loaded too early and overloaded.Would you accept a PR to remove that property?
The text was updated successfully, but these errors were encountered: