Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Uvicorn fails to properly shutdown process when using ctrl c from terminal #286

Closed
brendanboyle87 opened this issue Aug 13, 2024 · 1 comment
Assignees

Comments

@brendanboyle87
Copy link
Contributor

Hi all,

Thanks for putting together such a great framework! I just started learning and encountered an issue in nbs/tutorials/by_example.ipynb while using uvicorn app:app --reload to run my hello world app on Windows. As I went through the examples, I noticed that sometimes my webpage was still being served even when the server was shut down in my terminal (and server restarts would not pick up my changes). It looks like this issue is related to this GitHub issue.

I switched to using WSL, and everything worked fine. Perhaps the documentation could be updated to suggest this workaround for Windows users? I can open a PR for the update but wanted to check if this makes sense to the maintainers first.

@jph00
Copy link
Contributor

jph00 commented Aug 14, 2024

Sure, we'd be very happy to have such a doc update to suggest WSL. Note that docs live inside the notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants