Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complex hotwords support #Current Model Limitations Discussion #18

Open
amoazeni75 opened this issue Apr 10, 2022 · 8 comments
Open

complex hotwords support #Current Model Limitations Discussion #18

amoazeni75 opened this issue Apr 10, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@amoazeni75
Copy link

amoazeni75 commented Apr 10, 2022

Hi,
Thanks for your helpful research. I wonder if the current model can handle complex hot words like "Hey Siri" or just handle one word, like "Siri"?

My second question is about hot words that their pronunciation takes more than 1s, like"Hey XXXX." Does your model support changing the recording time?

Did you try to use cosine_similarity instead of Euclidian distance in inference time?

Thanks.

@dominickchen
Copy link

+1
We also want to use an about 2-seconds-long custom hotword, but with the current python -m eff_word_net.generate_reference method, the detection seems to be awkward.

So would like to have support changing the recording time too!

@TheSeriousProgrammer
Copy link
Member

TheSeriousProgrammer commented Apr 15, 2022

Sorry for the delayed response, the model was currently trained on single words , however its should work in simple phrases like Hey xxx though . Moreover the current model was trained on 1 sec audio clippings , so bizare behviour might occur on trying to process audio clippings greater in length than 1 sec
Pushed a commit c9dee14 expanining the same

The model was trained using Euclidean distance hence works on the same during inference time too

Coming to increasing hotword length, hotwords are usually small , may be we can extend the processing window to 1.5 sec , but 2 sec I am not really sure . Can you give a few examples where a hotword could be greater than 1.5 secs?

Kindly give you additional model suggestions in discussions page #3

Join the same channel and put forward you queries there , planning to create faster , more performant version of current implimentation soon, your suggestions will be helpful

@TheSeriousProgrammer TheSeriousProgrammer added the enhancement New feature or request label Apr 15, 2022
@TheSeriousProgrammer TheSeriousProgrammer self-assigned this Apr 15, 2022
@TheSeriousProgrammer TheSeriousProgrammer changed the title complex hotword complex hotwords support #Current Model Limitations Discussion Apr 15, 2022
@amoazeni75
Copy link
Author

Thanks for the Information.
An example of a long wake word is "Hey MercedesBenz".
Could you please provide the training steps?

@TheSeriousProgrammer
Copy link
Member

sorry for the delay , didn't have time to clean the repository which held the training code , the same is built using keras https://github.com/Ant-Brain/wakeword_dataset_generator . It has both the training code and dataset generator code

@Durgesh92
Copy link

Hey, thanks for this repo.

I can not find your training code here https://github.com/Ant-Brain/wakeword_dataset_generator . is it available in any other repo?

@TheSeriousProgrammer
Copy link
Member

TheSeriousProgrammer commented Jul 14, 2022

Extremely sorry for the delay, my bad forgot to add the notebook which contained the training code
https://colab.research.google.com/drive/1hH6q3cGneIWxNRLwbVAKIBzHoVVFlEO3?usp=sharing

@TheSeriousProgrammer
Copy link
Member

Currently working on a newer model with better perfomance and higher hotword length, will be available in a month's time

@TheSeriousProgrammer
Copy link
Member

TheSeriousProgrammer commented Apr 14, 2023

Update

A newer model with better resilience to noise, 1.5 secs window support has been added to the flow . kindly check it out!!
(its taken more than a month for the update XD )

@aman-17 aman-17 unpinned this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants