Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Rate Limit into Etherscan query engine .estimate_query method [APE-738] #76

Open
2 tasks
fubuloubu opened this issue Mar 21, 2023 · 0 comments
Open
2 tasks

Comments

@fubuloubu
Copy link
Member

Overview

Some queries are heavy via Etherscan API, so we will want to add rate limit logic to the query engine in order to bypass selecting it (or modify the request) so it doesn't fail with a EtherscanTooManyRequestsError

Specification

  • Update EtherscanQueryEngine.estimate_query to factor in the rate limit
  • Update EtherscanQueryEngine.perform_query to respect the rate limit when performing queries

Dependencies

n/a

@NotPeopling2day NotPeopling2day changed the title Integrate Rate Limit into Etherscan query engine .estimate_query method Integrate Rate Limit into Etherscan query engine .estimate_query method [APE-738] Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant