Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve Github.ListStargazers Pagination #135

Open
EricGustin opened this issue Oct 31, 2024 · 0 comments
Open

[Feature] Improve Github.ListStargazers Pagination #135

EricGustin opened this issue Oct 31, 2024 · 0 comments
Labels
new contributor friendly type: feature For backward-compatible new feature that will result in a minor version increment

Comments

@EricGustin
Copy link
Member

Description
The Github.ListStargazers tool paginates through stargazers in quantities of 100. The current algorithm for paginating allows for the number of stargazers to temporarily exceed the limit input parameter before returning the list. Improving this tool to never exceed the limit will help with performance.

Implementation Strategy
In this file, we could keep track of the remaining number of stargazers to get. We could then set the per_page param to be the min(per_page, remaining).

Use Case
Reduces data transmitted over the wire.
@EricGustin EricGustin added type: feature For backward-compatible new feature that will result in a minor version increment new contributor friendly labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new contributor friendly type: feature For backward-compatible new feature that will result in a minor version increment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EricGustin