Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed files do not get flagged for deletion #440

Open
julienbfabre opened this issue Jan 12, 2024 · 3 comments
Open

Removed files do not get flagged for deletion #440

julienbfabre opened this issue Jan 12, 2024 · 3 comments

Comments

@julienbfabre
Copy link

In my initializer asset_sync.rb:

config.existing_remote_files = "delete"
config.remote_file_list_cache_file_path = File.join(Rails.root, 'data', 'asset_sync_remote_file_list_cache.json')
config.remote_file_list_remote_path = 'asset_sync_remote_file_list_cache.json'

after deleting some files i ran rake assets:precompile again but the deleted files were not flagged for deletion and remained in S3:

% rake assets:precompile
AssetSync: using /myapp/config/initializers/asset_sync.rb
AssetSync: Syncing.
Using: Directory Search of /myapp/public/assets
Downloading file list file from remote
Updating file list file in remote
Fetching files to flag for delete
Flagging 0 file(s) for deletion
AssetSync: Done.

I checked and the deleted files are still listed in data/asset_sync_remote_file_list_cache.json.
What am i missing to get the deleted files to be noticed and removed from S3?

@PikachuEXE
Copy link
Member

I don't use this gem so I have no idea how to figure out what goes wrong until there is a test case :S

@julienbfabre
Copy link
Author

I don't use this gem so I have no idea how to figure out what goes wrong until there is a test case :S

@PikachuEXE i'm not i understand your reply, is there anything you need from me to help answer the question?

@PikachuEXE
Copy link
Member

I have no idea how to reproduce it in test case(s)
So I have no idea how to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants