You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your styling was a great part of the project. It was interesting, viewing the code, that the same few scss files were being imported in every component. Now that you have a good feel for how styles were managed across the app, take another look at what the best way to manage styling would be, and if you would change anything.
SCSS is doing a lot of work pre-processing your css. It is great to use when defining complex and overarching styles which will then be applied to the project as a whole as you've done here. The benefit of importing styles into each component comes with the idea of component composition and having the styles defined close to the component itself. Here you're mixing the two, defining an overarching style but then importing it individually into each component.
FEC-CatWalk/project/src/components/QuestionsAndAnswers/QuestionList/QuestionList.jsx
Line 6 in 5283dbc
Your styling was a great part of the project. It was interesting, viewing the code, that the same few scss files were being imported in every component. Now that you have a good feel for how styles were managed across the app, take another look at what the best way to manage styling would be, and if you would change anything.
SCSS is doing a lot of work pre-processing your css. It is great to use when defining complex and overarching styles which will then be applied to the project as a whole as you've done here. The benefit of importing styles into each component comes with the idea of component composition and having the styles defined close to the component itself. Here you're mixing the two, defining an overarching style but then importing it individually into each component.
This is vaguely introduced at the beginning here: https://create-react-app.dev/docs/adding-a-sass-stylesheet/
This is not a requirement to refactor or necessary in any way. But read into it and consider what you might do in the future!
The text was updated successfully, but these errors were encountered: