-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions chart broken if load balancer is used? #184
Comments
This snippet should get the versions from the audit log:
This should also include SSH connections. However, I wonder should take any Git client into considerations with a regex like this (note: I use the user instead of IP here too):
Even further we could look for other agents:
This would also record
@pluehne Could that be easily be made compatible with your versions check logic? Could everything not |
Previously we read the versions from the haproxy log and used the originating IP address to distinguish machines/users. In a load balancer setup this IP address can be the same for all requests and consequently the number of users per version are not counted correctly. Fix this by using the audit log to count the Git versions. Also count the versions by user ID and not by IP address. see #184
Previously we read the versions from the haproxy log and used the originating IP address to distinguish machines/users. In a load balancer setup this IP address can be the same for all requests and consequently the number of users per version are not counted correctly. Fix this by using the audit log to count the Git versions. Also count the versions by user ID and not by IP address. see #184
@larsxschneider: I just realize that you addressed most of this issue in #185, which we already merged. However, I like the idea of recording the client agents in |
The versions chart uses the
haproxy.log
to determine the Git client versions in use. This has two disadvantages:127.0.0.1
in the haproxy log and therefore we cannot distinguish different machinesThe text was updated successfully, but these errors were encountered: