Varia (and child themes): custom social menu is now outdated

[jeherve]

Quick summary

The Varia theme (and consequently all its child themes) bundles its own version of Jetpack's Social Menu feature:
https://github.com/Automattic/themes/blob/trunk/varia/inc/icon-functions.php

This custom version works well, but doesn't include recent changes to Social Menus in Jetpack, like the inclusion of new social networks like Bluesky.

Steps to reproduce

1. Start with a WordPress.com site where you've enabled the Varia theme or one of its child themes such as dalston.
2. Go to Appearance > Customize > Menus
3. Create a new menu and assign it to the social menu location.
4. In that menu, create 2 custom links: https://x.com/automattic and https://bsky.app/profile/ma.tt
5. Save your changes

A clear and concise description of what you expected to happen.

I expect both icons to appear in the social menu location:

What actually happened

On the frontend, the Bluesky icon will not be displayed.

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

[Robertght]

📌 REPRODUCTION RESULTS

• Tested on Simple – Replicated
• Tested on Atomic – Replicated
• Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

• Weirdly, this also happens on Atomic sites, but also with Twentytwenty themes. I tested 2021, 2020 and 2019. I assume the older ones behave the same.

• Blockbase themes don't appear to be affected

• Also, some themes display ok X while others don't.

📌 ACTIONS

• Triaged

@dsas I can see you have this on your radar. Do you want separate issues for the Twenty themes? Should I report these in core?

[dsas]

@Robertght Please keep this issue just for themes that are children of Varia. There's a linked issue for other themes, it sounds like the Core themes might be more nuanced.