Fix flakiness while creating a page with the checkout block #10340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
…c/woocommerce-payments into dev/10339-wcb-checkout
…c/woocommerce-payments into dev/10339-wcb-checkout
allie500
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for working on this fix, Eduardo! Everything looked good but as noted in our p1739194864927739/1738846788.754599-slack-C01B8KNUYSW, we uncovered some weird behavior when running all three specs in a row. The additional changes to fix that weird behavior look to be working as I'm now getting consistent passing tests.
LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10339
Changes proposed in this Pull Request
This PR aims to prevent possible flakiness in the tests that create a page with WC blocks checkout. The idea is that the action of clicking on the button to open the right sidebar can interfere with the action of searching for the checkout block, causing the test to fail.
Testing instructions
npm run test:e2e shopper-wc-blocks-checkout-failures.spec— the tests should passnpm run test:e2e shopper-wc-blocks-checkout-purchase.spec— the tests should passnpm run test:e2e shopper-wc-blocks-saved-card-checkout-and-usage.spec— the tests should passnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge