Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP does not recognize timer for ZG 5-piece timer #20

Open
lvangh opened this issue Aug 28, 2023 · 13 comments
Open

PP does not recognize timer for ZG 5-piece timer #20

lvangh opened this issue Aug 28, 2023 · 13 comments

Comments

@lvangh
Copy link

lvangh commented Aug 28, 2023

The Freethinker's 5 piece gives 10% to buff duration, making greater blessings 17 minutes, but the PP frames do not recognize the buff. I don't know if the spell ID is different - maybe a check for gear slots when the blessing is cast?

TY
image

@AznamirWoW
Copy link
Owner

I have no way of reproducing this.
You can try checking the buff on your character by using /dump UnitBuff("player", x) where x is from 1 to whatever until you find it.

See if it results in different outputs with and without the set.

@lvangh
Copy link
Author

lvangh commented Aug 29, 2023

Here is the 5pc version (17m)
image

Here is the standard 15m version
image

@lvangh
Copy link
Author

lvangh commented Aug 29, 2023

it looks like the time is 990 vs 900 so maybe check if the timer is greater than 900 set a flag for 5 piece and adjust the timers in PP buff list?

@AznamirWoW
Copy link
Owner

So what's the issue?
PallyPower does not see the buff as active?
or does it show a wrong expiration time?

With the same spell ID it should not matter how long the buff lasts. The buff duration is only used for calculating the recast penalty. This function check for the buff present:

/dump PallyPower:IsBuffActive("Blessing of Wisdom", "Greater Blessing of Wisdom", "player")

@lvangh
Copy link
Author

lvangh commented Aug 29, 2023 via email

@AznamirWoW
Copy link
Owner

Could you clarify (screenshot) what exactly wrong with the displayed time?

I just don't see how that is possible. The displayed time is the 1st value returned by IsBuffActive.

image

@lvangh
Copy link
Author

lvangh commented Aug 30, 2023

it's really odd because it doesn't seem to be consistent. Here is a screenshot from my raid on Sunday showing my buff timer at 16m and PP showing 14m. But just now while I tried it is showing the correct time - but the only difference here is that I'm not in a raid right now - just solo.

image

@AznamirWoW
Copy link
Owner

Try the same command in the raid, just change the blessing name

/dump PallyPower:IsBuffActive("Blessing of Wisdom", "Greater Blessing of Wisdom", "player")

@lvangh
Copy link
Author

lvangh commented Sep 1, 2023

Sorry to leave you hanging - haven't forgot about this just haven't had time to play - next raid I will post ASAP.

@lvangh
Copy link
Author

lvangh commented Nov 14, 2023

OK finally got back to playing a bit, and found another example (but not yet in a raid.)

I tested in a party - buff timer shows 17 minutes for ME, but not the other person in the party. Only 15m.

image

I get that it might just look like I staggered the buffs and might not help that much but what I'll do is record this in OBS and post something soon.

Sorry for the delay - hope this helps somewhat until then.
TY

@lvangh
Copy link
Author

lvangh commented Nov 15, 2023

So weird, today in a 40 raid it worked as intended and showed the correct times. I wonder if a backend spell ID was corrected? Keep this open for now until I can test more

@AznamirWoW
Copy link
Owner

So weird, today in a 40 raid it worked as intended and showed the correct times. I wonder if a backend spell ID was corrected? Keep this open for now until I can test more

I don't see any different spell ID in the database for the blessings, I think the game just sets the expiration time with some extra time.

@lvangh
Copy link
Author

lvangh commented Feb 28, 2024

Just keeping in touch with this - will try to test soon on Era and hopefully have an OBS recording. I haven't been able to play lately. ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants