From 6e3ad72167fea7e2a6f2ac3cca7c82b7257c704e Mon Sep 17 00:00:00 2001 From: benesjan Date: Fri, 31 Jan 2025 21:55:07 +0000 Subject: [PATCH] TODOs of optimization opportunities --- .../contracts/app_subscription_contract/src/main.nr | 1 + .../noir-contracts/contracts/claim_contract/src/main.nr | 1 + .../noir-contracts/contracts/crowdfunding_contract/src/main.nr | 1 + .../noir-contracts/contracts/token_bridge_contract/src/main.nr | 1 + 4 files changed, 4 insertions(+) diff --git a/noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr b/noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr index 821e9e79c84..f223b8a4a4c 100644 --- a/noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr +++ b/noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr @@ -18,6 +18,7 @@ contract AppSubscription { use router::utils::privately_check_block_number; use token::Token; + // TODO: This can be optimized by storing the values in Config struct in 1 PublicImmutable (less merkle proofs). #[storage] struct Storage { target_address: PublicImmutable, diff --git a/noir-projects/noir-contracts/contracts/claim_contract/src/main.nr b/noir-projects/noir-contracts/contracts/claim_contract/src/main.nr index 8d368e20759..5c6cdd96f5e 100644 --- a/noir-projects/noir-contracts/contracts/claim_contract/src/main.nr +++ b/noir-projects/noir-contracts/contracts/claim_contract/src/main.nr @@ -11,6 +11,7 @@ contract Claim { use dep::uint_note::uint_note::UintNote; use token::Token; + // TODO: This can be optimized by storing the addresses in Config struct in 1 PublicImmutable (less merkle proofs). #[storage] struct Storage { // Address of a contract based on whose notes we distribute the rewards diff --git a/noir-projects/noir-contracts/contracts/crowdfunding_contract/src/main.nr b/noir-projects/noir-contracts/contracts/crowdfunding_contract/src/main.nr index d1963ad50af..b3f16131197 100644 --- a/noir-projects/noir-contracts/contracts/crowdfunding_contract/src/main.nr +++ b/noir-projects/noir-contracts/contracts/crowdfunding_contract/src/main.nr @@ -31,6 +31,7 @@ contract Crowdfunding { amount: U128, } + // TODO: This can be optimized by storing the values in Config struct in 1 PublicImmutable (less merkle proofs). // docs:start:storage #[storage] struct Storage { diff --git a/noir-projects/noir-contracts/contracts/token_bridge_contract/src/main.nr b/noir-projects/noir-contracts/contracts/token_bridge_contract/src/main.nr index 02697ab8b53..be076e4fc29 100644 --- a/noir-projects/noir-contracts/contracts/token_bridge_contract/src/main.nr +++ b/noir-projects/noir-contracts/contracts/token_bridge_contract/src/main.nr @@ -24,6 +24,7 @@ contract TokenBridge { }; // docs:end:token_bridge_imports + // TODO: This can be optimized by storing the values in Config struct in 1 PublicImmutable (less merkle proofs). // docs:start:token_bridge_storage_and_constructor // Storage structure, containing all storage, and specifying what slots they use. #[storage]