From 03d9af06dc3c7e930890c318b76347966893d2be Mon Sep 17 00:00:00 2001 From: Arjen Huitema Date: Wed, 30 Oct 2024 23:17:43 +0100 Subject: [PATCH 1/2] Update eslzArm.json to handle empty parameters for service hook and email contact --- eslzArm/eslzArm.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eslzArm/eslzArm.json b/eslzArm/eslzArm.json index c9ec37efeb..ff3c2079eb 100644 --- a/eslzArm/eslzArm.json +++ b/eslzArm/eslzArm.json @@ -2268,7 +2268,7 @@ "value": "[parameters('userAssignedManagedIdentityName')]" }, "ALZWebhookServiceUri": { - "value": "[array(parameters('ambaAgServiceHook'))]" + "value": "[if(empty(parameters('ambaAgServiceHook')), null(), array(parameters('ambaAgServiceHook')))]" }, "ALZArmRoleId": { "value": "[array(parameters('ambaAgArmRole'))]" @@ -2283,7 +2283,7 @@ "value": "[deployment().location]" }, "ALZMonitorActionGroupEmail": { - "value": "[array(parameters('ambaAgEmailContact'))]" + "value": "[if(empty(parameters('ambaAgEmailContact')), null(), array(parameters('ambaAgEmailContact')))]" }, "managementSubscriptionId": { "value": "[parameters('managementSubscriptionId')]" From c9eec9d7e860d551dd9784568c651392da6c6f18 Mon Sep 17 00:00:00 2001 From: Arjen Huitema Date: Thu, 31 Oct 2024 00:42:15 +0100 Subject: [PATCH 2/2] Fix Portal Accelerator issue with Azure Monitor Baseline Alerts notifications for empty Email and Service Hook settings --- docs/wiki/Whats-new.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/wiki/Whats-new.md b/docs/wiki/Whats-new.md index 9779d7408e..d31a725ab0 100644 --- a/docs/wiki/Whats-new.md +++ b/docs/wiki/Whats-new.md @@ -75,6 +75,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones: - Resolved a bug in the Portal Accelerator related to deploying the single platform subscription setup. Incorrect parameter settings led to the failure of AMBA, as it erroneously attempted to deploy to a standard management group structure instead of a single platform management group as needed. - Increasing Policy assignment delay by a couple of minutes to help reduce assignment errors using the portal accelerator experience (the infamous "please wait 30 minutes and try again" error). +- An issue with the Portal Accelerator regarding the Azure Monitor Baseline Alerts notifications settings was resolved. The problem occurred when no Email Address or Service Hook was specified on the Baseline alerts and monitoring tab. In this scenario, an empty string was converted to an array, resulting in the format `[""]` instead of `[]`. This caused errors during the remediation of the Notification Assets initiative. ### September 2024